mkv fixes and laces support #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when reading frames, need to read a bit extra in order to have the headers of the frame following the last frame of the segment (in order to calcuation the duration of the last frame) in addition to reading a few bytes extra, need to ignore overflow when parsing the cluster/simple-block elements of the next-segment frame, since usually this frame is not read in full.
- a block group is a key frame if it has no block references (unlike simple groups which use flags & 0x80) - also improved debug logs - added per-lace debug log, including the absolute file offset, size, key frame etc
can significantly reduce the read overhead - on some sample content that was tested, the read overhead (=total_frame_size_read - total_output_size) was reduced by 44%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when reading frames, need to read a bit extra in order to have the headers of the frame following the last frame of the segment (in order to calcuation the duration of the last frame)
in addition to reading a few bytes extra, need to ignore overflow when parsing the cluster/simple-block elements of the next-segment frame, since usually this frame is not read in full.